This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Implement API rate limits #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would raise the limit per minute. Skipping through more than 5 pages and adapting the filter several times (= one requests each) is quite normal. I would set it to 40 the least. Bigger crawlers will be stopped by the hour wise rate limit. |
|
I think its a rather technical setting, so it should go to |
|
After long negotiations, we settled for 15/min |
|
@feeds Mind leaving a review? 😄 |
|
@feeds @bjrne @maltezacharias Anyone? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this settings, a user is only allowed to retrieve 15*100=1500 users per day. @match4everyone/match4everyone Currently, this has to be changed in the
settings/common.pyand not like inA.pyandB.py. Do we want to expose such general settings also in something like ageneral.pyor should we just document that the user has to change that insettings/common.py?Closes #177
Depends on #173