(React) [FooterSlim] fix markup semantic #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairesunstudio
changed the title
|
@clairesunstudio Is this in a new release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
component: FooterSlim
description: Fix markup semantic and classnames. ((React) [FooterSlim] fix markup semantic #1148)
issue: [React] FooterSlim includes an <h3> which could be confusing for screen readers #1146
impact: Patch
This PR:
1 . Addressed the issue that Sawyer submitted #1146 and based on discussion with @ygannett in Slack https://mass-digital.slack.com/archives/CB9JM3NLS/p1597162560078700
2. Renamed the classes to match BEM convention
block__element--modifier3. Moved font-weight style of headings into the ma-heading mixin