Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] FooterSlim includes an <h3> which could be confusing for screen readers #1146

Open
sawyerh opened this issue Aug 11, 2020 · 2 comments

Comments

@sawyerh
Copy link

sawyerh commented Aug 11, 2020

Mayflower version: @massds/mayflower-react" 10.0.0-alpha.2

The FooterSlim component includes an h3, which can result in inaccurate heading ordering, since there isn't a parent h2. This could be confusing to screen reader users who navigate by headings. A more accurate heading level would be an h2 (or no heading?)

@sawyerh
Copy link
Author

sawyerh commented Aug 11, 2020

Screenshot from Lighthouse related to this:

image

@clairesunstudio
Copy link
Contributor

Thanks for noticing and submitting mayflower issues as always! Here's a PR for your review. Based on the conversation with @ygannett, we decided to go with removing the heading and using <div> in places of <section> in the Footer. Please review the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants