get summary without feature flag #837
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frimpongopoku
commented
Nov 9, 2023
frimpongopoku
commented
- If there are no feature flags, it will summarise duplicates for all communities
BradHN1
reviewed
Nov 9, 2023
| @@ -33,7 +33,10 @@ def remove_duplicate_images(task): | |||
| print("Generating hashes") | |||
| result = media_store.generate_hashes(None, None, None) | |||
|
|
|||
| communities = flag.enabled_communities() | |||
| if flag and do_updates: | |||
| communities = flag.enabled_communities() | |||
There was a problem hiding this comment.
I think if the flag is enabled, but no communities selected, this will produce an empty queryset and it will not do any reporting on duplicates, but probably blow up.
|
There is some test code that got in there, my mistake. Note two calls to generate_hashes where I had added one before I saw you had. Also an IF_LOCAL in the MEDIA_LIBRARY - doesnt' do anything except print out. |
|
@frimpongopoku @BradHN1 is this PR still useful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.