new route to help img cropping for already uploaded image (to skip CO… #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
abdullai-t
reviewed
Oct 26, 2023
|
Unit tests for new route? |
Incoming 🚗 |
|
BradHN1
reviewed
Nov 7, 2023
BradHN1
approved these changes
Nov 7, 2023
They have already been replaced in new PRs. I will clear them out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with frontend PR: massenergize/frontend-admin#1108
Note
To be able to implement cropping, we need to be able to read the image data. Doing that with a just-selected image from a user's device is straight forward. But for an image that has been uploaded, you need to be able to load the image via the link and try to read it's content. Doing that with the image links we have gives a cross-origin error (CORS). That is why I had to make a route that reads the image data and sends it to the frontend to be able to continue.
Things would have been easier and more straight forward if we could simply read the data from the image that is loaded. And I think that could probably be done with adding some new policies to our image buckets on AWS to looses the grip on accepted origins, but that might open us up to our images being used in various places we might not like... so as you can see the PR, I went with the B.E route which works nicely. 🤣 🤣 👌🏾