Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon Calculator bug fixes, and bugs uncovered by unit tests #814

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

BradHN1
Copy link
Contributor

@BradHN1 BradHN1 commented Oct 17, 2023

Summary / Highlights

Fixes several bugs encountered in testing

Details (Give details about what this PR accomplishes, include any screenshots etc)

Three bugs in API for undefined variable user_media_upload
Two CC bugs: one fixing unitialized variables in CalculatorAction model, another for new CC Actions without associated Questions.

Testing Steps (Provide details on how your changes can be tested)

Unit tests pass.
Calculator actions titles not missing in Edit Action in Admin portal

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've tested my changes manually.
  • I've added unit tests to my PR.
Transparency (Project board)
  • I've given my PR a meaningful title.
  • I linked this PR to the relevant issue.
  • I moved the linked issue from the "Sprint backlog" to "In progress" when I started this.
  • I moved the linked issue to "QA Verification" now that it is ready to merge.

@BradHN1 BradHN1 added bug Something isn't working API API priority 1 labels Oct 17, 2023
@BradHN1 BradHN1 requested a review from frimpongopoku October 17, 2023 17:44
@BradHN1 BradHN1 merged commit 2e2386e into development Oct 17, 2023
1 check passed
@BradHN1 BradHN1 deleted the BHN-bugfixes branch October 24, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API bug Something isn't working priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant