Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User portal copyright with images #813

Merged
merged 12 commits into from
Oct 16, 2023

Conversation

frimpongopoku
Copy link
Contributor

@frimpongopoku frimpongopoku commented Oct 13, 2023

Works with Frontend PR : massenergize/frontend-portal#1269

  • Backend changes that allow copyright information when user uploads via user portal.
  • media field validation now abstracted into the "expect_media_fields" function
  • Uploading via user portal automatically marks image to be open to the community they are currently in

if community:
event.community = community
else:
event.community = None
Copy link
Contributor

@BradHN1 BradHN1 Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should give an error. Specified a community_id but ommunity didn't exist. Existing bug...


goal["organic_attained_carbon_footprint_reduction"] = carbon_footprint_reduction

# calculate values for community impact to be displayed on front-end sites
impact_page_settings: ImpactPageSettings = ImpactPageSettings.objects.filter(community__id=self.pk).first()
impact_page_settings: ImpactPageSettings = ImpactPageSettings.objects.filter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

half the time when one of you guys does a reformatting like this, the other one changes it back. Maybe depends on your mood?

Copy link
Contributor

@BradHN1 BradHN1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradHN1 BradHN1 merged commit eb5476e into development Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants