Fix: Enhance URLResolverMiddleware to support host-based path resolution #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullai-t
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 58.66% 58.71% +0.05%
==========================================
Files 498 499 +1
Lines 37130 37176 +46
==========================================
+ Hits 21781 21829 +48
+ Misses 15349 15347 -2 ☔ View full report in Codecov by Sentry. |
HeyMrQuaidoo
reviewed
Dec 5, 2024
| if request.path == '/': | ||
| resolved_path = f'/{current_host}' | ||
| else: | ||
| resolved_path = f'/{current_host}{request.path}' |
There was a problem hiding this comment.
Can we add tests for this ? @abdullai-t Would request.path have a / preceding it or would current_host have a trailing slash / ?
…ove path resolution logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
This pull request introduces significant changes to the
src/api/middlewares/url_resolver_middleware.pyfile, focusing on improving URL resolution and handling of host-specific paths. The key changes include the addition of a host map and a new method for resolving paths.Enhancements to URL resolution:
host_patternsfrom_main_.hostsand initialized ahost_mapto map host regex patterns to host objects.resolvewith a new method_resolve_paththat constructs host-specific paths and resolves them.__call__method to use_resolve_pathfor resolving request paths and setrequest.path_infoaccordingly.New method for path resolution:
_resolve_pathmethod to handle host-specific path resolution and return the resolved path orNoneif the path cannot be resolved.Details (Give details about what this PR accomplishes, include any screenshots etc)
Testing Steps (Provide details on how your changes can be tested)
Requirements (place an
xin each[ ])Transparency (Project board)