refactor: Update feature flag keys #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullai-t
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 57.55% 57.72% +0.17%
==========================================
Files 491 493 +2
Lines 36027 36091 +64
==========================================
+ Hits 20736 20835 +99
+ Misses 15291 15256 -35 ☔ View full report in Codecov by Sentry. |
HeyMrQuaidoo
requested changes
Dec 4, 2024
src/api/store/event.py
Outdated
| return None, NotAuthorizedError() | ||
|
|
||
| event_community = events.first().community | ||
| if event_community: |
There was a problem hiding this comment.
Why isn't this a single condition ?
if event_community:
if not is_admin_of_community(context, event_community.id):
There was a problem hiding this comment.
did that in the latest push
| @@ -310,8 +310,8 @@ def _base_community_query(is_sandbox): | |||
|
|
|||
| def _get_file_url(image): | |||
| if not image: | |||
| return None | |||
| return image.file.url if image.file else None | |||
| return "" | |||
There was a problem hiding this comment.
Can you add test coverage for this. @abdullai-t
…e test coverage for file URL retrieval
HeyMrQuaidoo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
This pull request includes several changes to improve feature flag management, error logging, and community event handling. It also introduces a new test case for the testimonial nudge feature.
Feature Flag Management:
SHARED_TESTIMONIALS_NUDGE_FFfeature flag toTESTIMONIAL_AUTO_SHARE_SETTINGS_NUDGE_FEATURE_FLAG_KEYin multiple files for consistency. [1] [2] [3]Error Logging:
loginmethod by removing thelevel="error"parameter fromlog.errorcalls.Community Event Handling:
delete_eventmethod to handle the case where the community of an event might beNone.download_datamethod to remove an unused parameter from thesend_events_reportfunction call.infomethod to returnNonefor the community if it does not exist.Testing:
cadmin_testimonial_nudgefeature, including setup and teardown methods, and tests for retrieving community admin names and emails, as well as preparing testimonials.Other Changes:
_get_file_urlfunction to return an empty string instead ofNonewhen an image is not present.Details (Give details about what this PR accomplishes, include any screenshots etc)
Testing Steps (Provide details on how your changes can be tested)
Requirements (place an
xin each[ ])Transparency (Project board)