Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor prints to log & ensure local|test mode don't send logs to se… #1109

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Opoku-Agyemang
Copy link
Contributor

Summary / Highlights

refactor prints to log & ensure local|test mode don't send logs to sentry and cloud watch

Details (Give details about what this PR accomplishes, include any screenshots etc)

Testing Steps (Provide details on how your changes can be tested)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've tested my changes manually.
  • I've added unit tests to my PR.
Transparency (Project board)
  • I've given my PR a meaningful title.
  • I linked this PR to the relevant issue.
  • I moved the linked issue from the "Sprint backlog" to "In progress" when I started this.
  • I moved the linked issue to "QA Verification" now that it is ready to merge.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 22.69504% with 109 lines in your changes missing coverage. Please review.

Project coverage is 55.02%. Comparing base (3472571) to head (6851311).

Files Patch % Lines
src/api/store/community.py 0.00% 33 Missing ⚠️
src/api/store/misc.py 0.00% 15 Missing ⚠️
src/apps__campaigns/create_campaign_template.py 0.00% 14 Missing ⚠️
src/task_queue/nudges/user_event_nudge.py 18.18% 9 Missing ⚠️
src/task_queue/views.py 12.50% 7 Missing ⚠️
src/carbon_calculator/carbonCalculator.py 20.00% 4 Missing ⚠️
src/task_queue/nudges/cadmin_events_nudge.py 20.00% 4 Missing ⚠️
src/_main_/settings.py 25.00% 3 Missing ⚠️
src/task_queue/nudges/postmark_sender_signature.py 25.00% 3 Missing ⚠️
src/_main_/utils/GeoIP.py 0.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   54.96%   55.02%   +0.05%     
==========================================
  Files         438      438              
  Lines       32470    32461       -9     
==========================================
+ Hits        17848    17861      +13     
+ Misses      14622    14600      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant