Fix: Handling Existing Campaign Followers #1045
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error handling to prevent duplicate campaign followers. This is achieved by returning an error if a 'get_or_create' operation yields an existent campaign follower. This will minimize potential conflicts in the CampaignFollow objects.
archx3
approved these changes
Jun 18, 2024
|
@abdullai-t any update on this PR? |
…ampaign-follow
Modified the test_campaigns integration test to include email within the payload for the "campaigns.follow" endpoint. The changes were made for both community admin and user test scenarios.
The python-bidi library has been added to the project's dependencies in the requirements.txt file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
- Coverage 55.25% 55.23% -0.02%
==========================================
Files 440 440
Lines 32608 32610 +2
==========================================
- Hits 18017 18013 -4
- Misses 14591 14597 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
This pull request fixes the bug that returns success when a user subscribes to a campaign with the same information multiple times.
Details (Give details about what this PR accomplishes, include any screenshots etc)
Testing Steps (Provide details on how your changes can be tested)
Requirements (place an
xin each[ ])Transparency (Project board)