Update React UI package for ES5 compilation and TS source #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarikhamilton
force-pushed
the
typescript-mdl-react
branch
from
9dab82d to
0e54c3d
Compare
The important thing here was that I cleared the lock file when installing React. This may work with 16.4 too, but let's move on sooner rather than later. It's a backwards compatible update. Setting appBg white makes the action panel white too, and you cannot target it for the life of it, so I updated the storybook.scss. Even though the BG is explicitly set white, the background changer still works.
Uh-oh. I believe the React component source should live inside the React package, otherwise the changes aren't really detected. That's another discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.