chore(cleanup): Get rid of priority multiaddr, publish all of a node's multiaddresses #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcamou
requested review from
mudler and
a team
and removed request for
mudler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 12.40% 11.35% -1.06%
==========================================
Files 93 93
Lines 6770 6640 -130
==========================================
- Hits 840 754 -86
+ Misses 5854 5827 -27
+ Partials 76 59 -17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing local testing I found a problem: a node was only publishing its external IP address (found by connecting to an external service). The issue was that, when running 2 nodes in my LAN for testing, they were trying to connect via the external IP, which my router does not allow.This is completely unnecessary with Libp2p (the "priority multiaddr" was there because of some long-removed legacy code). Libp2p will publish all the multiaddrs that it knows about, and when a node connects to another node it will also add to the DHT the address as observed by the other node. So let's let libp2p do its thing and forget about this "priority multiaddr" shenanigans.
Notes for Reviewers
Signed commits