Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix handling of the privateKeyFile and api-enabled options #640

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Nov 28, 2024

Description

This PR fixes # the handling of the privateKeyFile and api-enabled options.

privateKeyFile wasn't being correctly processed if the masaDir was changed

api-enabled should use the constant defined for that purpose instead of inlining the value

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 12.52%. Comparing base (eaa4303) to head (5199c9b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/app.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   12.71%   12.52%   -0.19%     
==========================================
  Files          93       93              
  Lines        6766     6770       +4     
==========================================
- Hits          860      848      -12     
- Misses       5831     5847      +16     
  Partials       75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcamou
Copy link
Contributor Author

mcamou commented Nov 28, 2024

@restevens402 Regarding the PageSize issue you found, that should be taken care of by always using WithConstantOptions, although if that happened to you it might be a Good Idea ™️ to rethink the ConstantOption handling a little bit so that it's impossible to NOT do it (and yet give a chance to change it if needed). Or am I perhaps misunderstanding what the issue was?

@mcamou mcamou requested review from a team and removed request for mudler and restevens402 November 28, 2024 18:56
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mcamou mcamou merged commit 04d2136 into main Nov 29, 2024
11 of 13 checks passed
@mcamou mcamou deleted the mc/options branch November 29, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants