fix(twitter): update package and follower response type to Profile #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update twitterscrpaer package - Change return type from Legacy to *Profile to match twitter-scraper API - Update import to use imperatrona/twitter-scraper package - Fix type compatibility with FetchFollowers method
|
PR description is too short and seems to not fulfill PR template, please fill in |
|
@mudler this affects masa-finance/tee-worker#13 |
mcamou
approved these changes
Nov 26, 2024
teslashibe
deleted the
fix(twitter)-update-twitterscraper-package-and-follower-response-type-to-Profile
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 12.46% 12.41% -0.05%
==========================================
Files 93 93
Lines 6739 6766 +27
==========================================
Hits 840 840
- Misses 5823 5850 +27
Partials 76 76 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Update TwitterScraper Package Follower Response Type
Description:
Updates the Twitter Scraper package to use: https://pkg.go.dev/github.com/imperatrona/twitter-scraper and updated the follower scraping functionality to use the correct return type from the imperatrona/twitter-scraper package. This change:
Testing: