Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not bundle .env file while building the image #635

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Nov 21, 2024

Description

Fixes:


#20 CACHED

#21 [linux/arm64 base 7/7] COPY --chown=masa:masa .env .
#21 ERROR: failed to calculate checksum of ref s71w92flz0ldd9l9jgytucp8r::835vi4nvw90awwkc3l6bvbeqe: "/.env": not found

This pull request includes changes to the Dockerfile and docker-compose.yaml to improve the configuration and startup process for the application. The most important changes include modifying the command in the Dockerfile to adjust the --validator flag (this was causing the container to not start) and updating the docker-compose.yaml to mount the .env file as a volume.

Configuration and startup improvements:

  • Dockerfile: Modified the CMD instruction to adjust the --validator flag, ensuring it is correctly passed as a boolean flag.
  • docker-compose.yaml: Added a volume mount for the .env file to ensure environment variables are correctly loaded into the container.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler mudler marked this pull request as ready for review November 21, 2024 17:01
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.76%. Comparing base (979fb4c) to head (a3ff68c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   12.46%   12.76%   +0.29%     
==========================================
  Files          93       93              
  Lines        6739     6739              
==========================================
+ Hits          840      860      +20     
+ Misses       5823     5804      -19     
+ Partials       76       75       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mudler mudler changed the title fix(ci): do not copy .env file in the image fix(ci): do not bundle .env file while building the image Nov 21, 2024
@mudler mudler requested a review from a team November 21, 2024 17:15
@mudler mudler merged commit bf277c6 into main Nov 21, 2024
21 checks passed
@mudler mudler deleted the fix/container_image branch November 21, 2024 17:16
mudler added a commit that referenced this pull request Dec 3, 2024
fix(ci): do not copy .env file in the image

Signed-off-by: mudler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants