Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add GHA pipeline to publish container images #634

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Nov 20, 2024

Description

This PR fixes #396

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.46%. Comparing base (cc24d57) to head (ef0c240).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   12.46%   12.46%           
=======================================
  Files          93       93           
  Lines        6739     6739           
=======================================
  Hits          840      840           
  Misses       5823     5823           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mudler mudler marked this pull request as ready for review November 20, 2024 17:16
@mudler mudler requested a review from a team November 20, 2024 17:20
Copy link
Contributor

@mcamou mcamou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY minor suggestion, otherwise looks good!

.github/workflows/images.yml Outdated Show resolved Hide resolved
mcamou
mcamou approved these changes Nov 20, 2024
mcamou
mcamou approved these changes Nov 20, 2024
mcamou
mcamou previously approved these changes Nov 20, 2024
Co-authored-by: Mario Camou <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
@mudler mudler merged commit 979fb4c into main Nov 20, 2024
8 of 9 checks passed
@mudler mudler deleted the dockerhub branch November 20, 2024 17:54
mudler added a commit that referenced this pull request Dec 3, 2024
* chore(ci): add GHA pipeline to publish container images

Signed-off-by: mudler <[email protected]>

* Update .github/workflows/images.yml

Co-authored-by: Mario Camou <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>

---------

Signed-off-by: mudler <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Co-authored-by: Mario Camou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Container images release
2 participants