Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): Remove all LLM functionality #626

Merged
merged 5 commits into from
Nov 13, 2024
Merged

chore(cleanup): Remove all LLM functionality #626

merged 5 commits into from
Nov 13, 2024

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Nov 11, 2024

Description

As per a Slack conversation, all LLM functionality needs to be killed. We'll do it in a single, separate PR so that it can be easily revived if necessary.

Notes for Reviewers

Don't you just love deleting code? I love the feel of the Delete key in the morning.

Signed commits

  • Yes, I signed my commits.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 10.43%. Comparing base (c58fe2a) to head (d771f23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/workers/types/work_types.go 0.00% 4 Missing ⚠️
node/oracle_node.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main     #626      +/-   ##
=========================================
+ Coverage   8.82%   10.43%   +1.61%     
=========================================
  Files         99       93       -6     
  Lines       7809     6708    -1101     
=========================================
+ Hits         689      700      +11     
+ Misses      7046     5934    -1112     
  Partials      74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcamou mcamou requested a review from a team November 11, 2024 18:15
@mcamou mcamou changed the title Remove sentiment analysis since it's no longer called from anywhere chore(cleanup): Remove sentiment analysis since it's no longer called from anywhere Nov 11, 2024
@mcamou
Copy link
Contributor Author

mcamou commented Nov 12, 2024

Force-push after rebasing on top of main after merging #625

@mcamou mcamou changed the title chore(cleanup): Remove sentiment analysis since it's no longer called from anywhere chore(cleanup): Remove all LLM functionality Nov 13, 2024
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh yes!

@mcamou mcamou merged commit 5d12c5e into main Nov 13, 2024
12 of 13 checks passed
@mcamou mcamou deleted the mc/rm-sentiment branch November 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants