chore(refactor): move node logic to the node package #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this supposed to be part of v0.8 or some other release? |
39 tasks
Signed-off-by: mudler <[email protected]>
the earlier the better! |
restevens402
previously approved these changes
Sep 18, 2024
commit 4940215 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Sep 18 19:47:58 2024 +0200 build(deps): bump github.com/ollama/ollama from 0.3.9 to 0.3.11 (#558) Bumps [github.com/ollama/ollama](https://github.com/ollama/ollama) from 0.3.9 to 0.3.11. - [Release notes](https://github.com/ollama/ollama/releases) - [Commits](ollama/ollama@v0.3.9...v0.3.11) --- updated-dependencies: - dependency-name: github.com/ollama/ollama dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit b3022cc Author: Ettore Di Giacinto <[email protected]> Date: Wed Sep 18 16:16:09 2024 +0200 chore(ci): rename gosec workflow Signed-off-by: Ettore Di Giacinto <[email protected]> commit 7afe67f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Sep 17 17:46:35 2024 +0200 build(deps): bump github.com/gotd/td from 0.108.0 to 0.110.0 (#555) Bumps [github.com/gotd/td](https://github.com/gotd/td) from 0.108.0 to 0.110.0. - [Release notes](https://github.com/gotd/td/releases) - [Commits](gotd/td@v0.108.0...v0.110.0) --- updated-dependencies: - dependency-name: github.com/gotd/td dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d2a7aef Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Sep 17 17:46:16 2024 +0200 build(deps): bump github.com/sashabaranov/go-openai from 1.29.1 to 1.29.2 (#554) build(deps): bump github.com/sashabaranov/go-openai Bumps [github.com/sashabaranov/go-openai](https://github.com/sashabaranov/go-openai) from 1.29.1 to 1.29.2. - [Release notes](https://github.com/sashabaranov/go-openai/releases) - [Commits](sashabaranov/go-openai@v1.29.1...v1.29.2) --- updated-dependencies: - dependency-name: github.com/sashabaranov/go-openai dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Untie blockchain as a singleton, make it possible to create more instances - Allow to add protocols from the MasaOracle - Untie worker manager and avoid singleton Signed-off-by: mudler <[email protected]>
- Untie config from viper business logics - Now options are consistently used inside the node rather the config singletons - Reduce usage of config's singleton - Generate options from Viper configuration - Attach services to main node business logic to start up services Signed-off-by: mudler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains some small refactoring. My objective is to run tests for the blockchain, and in order to do this, I need to move from the
mainthe handler registration such as can be re-used when starting the node inside the tests.Changes breakdown:
pkg/into it's ownnode/package (the masa oracle node).AppOptionfor injecting generic "handlers" and "services" - in order to force the future code to use that structure instead of being loosely handled.configas singleton in favor ofAppOptionsAppOptionsto NodeAppOptionsto set services and handlersThis is still WIP, however could be merged as-is for now. The only drawback is that I haven't had the time to migrate yet current handlers and services to the new structure, and didn't moved things out of main yet.
Notes for Reviewers
Signed commits