feat: Telegram api #434
Closed
feat: Telegram api #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Do not merge yet, need to update work model for message scraping/LLM requests. |
mudler
reviewed
Jul 29, 2024
| client *telegram.Client | ||
| once sync.Once | ||
| appID = 28423325 // Your actual app ID | ||
| appHash = "c60c0a268973ea3f7d52e16e4ab2a0d3" // Your actual app hash |
There was a problem hiding this comment.
are these two used in the code? why we have hardcoded values here?
mudler
reviewed
Jul 29, 2024
| } | ||
|
|
||
| clientCtx, cancelClient = signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM) | ||
| defer cancelClient() |
There was a problem hiding this comment.
might be this causing the context to be closed prematurely maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #312 , #357 , #358
Notes for Reviewers
Implemented all 3 tickets.
Signed commits