-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ledger #392
feat: ledger #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes overall looks good, however:
- Above nitpicks
- Please split the work of ci: Run unit tests in github actions runners #369 in a separate PR, as we don't seem to bring any unit test with these changes, no need to add it here.
- The title and description are copied verbatim from the issue feat: On chain ledger #380 which doesn't add much context. The PR title/description can be improved so that shows the changeset introduced with the PR. Please see https://www.conventionalcommits.org/en/v1.0.0/ for guidance
- The test file added is called
e2e
but it is introducing unit tests, not e2e tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Blocks are clean and straightforward. Let's go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes requested but ignored - some of them are nitpicks, but I think some of these needs to be addressed before merging:
- please split the release note changes to a separate PR
- update the PR title/description to match the changeset
- brittle pointer dereference
Otherwise looks good - nice job!
re: commitlint, if you rebase on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! great job 🥳
Signed-off-by: mudler <[email protected]>
As part of #345 we have decided to go with our on-chain ledger rather then using another third party ledger.
The key takeaways are:
our own ledger that can store a limited set of data in the on-chain ledger. The ledger is implemented similarly to what EdgeVPN uses.
The ledger can be used to store a CID (content addressable ID) to reference a data that is carried over with the ledger. that for instance can be used to store big files or content that doesn't fit the ledger (see also #345 (comment) )
The ledger can be written only by trusted nodes, but can be read by all nodes of the network
For development, we can also point to an IPFS CID that is then pinned by the oracle nodes. That would allow us to quickly iterate in the short term while we develop a CID system inside our own protocol.
This card is about wrapping up the esperimental PR work in #350 and have it merged in the repository.
Describe alternatives you've considered
Using an external blockchain as a ledger (see discussions in #345)
Acceptance criteria
#350 is wrapped up and merged in the codebase