Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Aether-Legacy Inventory switch #64

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Petschko
Copy link

@Petschko Petschko commented Nov 15, 2020

Well I requested it, but instead of just hoping stuff gets implemented, i think its better when I contribute

Related: #58

The-Aether-Legacy is this Mod, but it only works until version "1.4.4" (I didn't tested it for the newer versions to be honest, may it still works)

@maruohon
Copy link
Owner

You shouldn't include all this random stuff in the same PR. One PR should be one coherent change. Also I don't want to include the dependency libraries in the repo directly, just the dependency line in build.gradle (possibly commented out by default).

For example I don't want to merge in all the random Gradle script changes and Gradle version change in the wrapper config. I have been using Gradle 2.14.1 for all my 1.12.x mods and I don't intend to change that as I know that version works and there is no need to change it at this point. On the other hand all my 1.13.2+ mods use Gradle 4.9.

Also as a note based on the PRs from yesterday, AFAIK you can push or even force push to the same branch to update the PR, there is no need to close and create a new PR to make those changes.

@Petschko
Copy link
Author

All right! Hehe sorry didn't did PRs that often

I can do one with all my changes later, removing all the gradle-build changes

@maruohon
Copy link
Owner

Also as another note, I'm not entirely sure if I want to include any more mod-specific inventory swapping support anyway. I'm not really looking forward to adding a number of new dependencies to the mod and to my dev environment. There are other big issues with the whole per-dimension inventory feature anyway, such as any form of modded ender chests or similar effectively bypassing all of this anyway.

One thing I've been considering is just swapping the entire player data, which, depending on how and where mods save their custom slots and stuff, may or may not automatically handle a number of other mod inventories.

@Petschko
Copy link
Author

Well for that I included a mod which disallow uses of certain blocks in the Dimension, the problem was only the inventory, which does your mod pretty well if you ask me.
Your mod just does the inventory and that pretty good!

I don't mind if you include these changes, i made it mostly for me, just though i can share them

@maruohon
Copy link
Owner

I think I'll try the entire player data swapping first, and I'll make a build of that for you to test with. But I have several other mods I'm also working on so I'm not sure when exactly I'll have the time to do that.

@Petschko
Copy link
Author

Petschko commented Nov 16, 2020

Yeah i can test it for you! Just ping me here again with the Test-Build then!

Also I agree with you that the more less dependencies, the better =)

As long you don't did it, i can use my compiled version of this mod, since it works flawlessly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants