Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add mkcron #2064

Closed
wants to merge 1 commit into from
Closed

build: add mkcron #2064

wants to merge 1 commit into from

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented Apr 18, 2024

Simple cron schedule expression editor for Linux Desktop

Log: add software name--mkcron
mkcron

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Simple cron schedule expression editor for Linux Desktop

Log: add software name--mkcron
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,Icon字段从${SNAP}/meta/gui/icon.png更改为MkCron,需要确认这是否是预期的更改,以及是否有相应的图标文件MkCron存在于 snap 包中。
  • mkcron.pro文件中,target.path的默认规则被注释掉了,这可能会影响包的部署路径。如果这是预期的更改,建议添加注释说明原因。
  • target.path的值被硬编码为$$PREFIX/bin,这可能会限制在特定部署环境中使用该包的灵活性。建议使用环境变量或配置文件来设置路径。
  • desktop.filesicons.files被添加到INSTALLS中,但未看到对应的文件../snap/gui/MkCron.png../snap_launcher/mkcron.desktop是否存在于项目中。如果这些文件不存在,这可能会导致安装失败。

是否建议立即修改:

  • 确认MkCron图标是否存在于 snap 包中,并更新图标路径为正确的值。
  • 添加注释说明为什么需要注释掉target.path的默认规则,以及如何部署该包。
  • 避免硬编码路径,使用环境变量或配置文件来设置路径,以提高代码的灵活性和可配置性。
  • 确保../snap/gui/MkCron.png../snap_launcher/mkcron.desktop文件存在于项目中,或者相应地修改INSTALLS中的文件列表。

@kamiyadm
Copy link
Contributor

提示QtwebEngine not found

@kamiyadm kamiyadm closed this May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants