Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix percentage typo on precipitation #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix percentage typo on precipitation #672

wants to merge 1 commit into from

Conversation

PragmaTwice
Copy link

@PragmaTwice PragmaTwice commented Mar 17, 2022 •
edited
Loading 

String.format(Locale.ENGLISH, "%d%%", (int) (percentOfPrecipitation * 100)

In this code, if percentOfPrecipitation is 0.58, the result string will be 57%.
Using Math.round can solve this problem.

@jwierzbi
Copy link

jwierzbi commented Nov 2, 2022 •
edited
Loading

Pretty sure this will also fix the issue I'm seeing (the 28.99999999... value):

Screenshot_20221028-105942

Can we get this CR merged please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @jwierzbi