Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture logs while initializing plugins #749

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

uklotzde
Copy link
Contributor

No description provided.

@martpie
Copy link
Owner

martpie commented Mar 16, 2024

Thanks for that, I was wondering why logging was not working in plugins.

Let me create an official tauri branch for all that, and we can start merging things there (I use stacked diffs for #748, so I'm basically force-pushing all the time).

The branch is still missing a few critical pieces, but I can create new PRs for these

@martpie martpie changed the base branch from pr748 to tauri March 16, 2024 21:46
@martpie
Copy link
Owner

martpie commented Mar 16, 2024

(bis) Due to force-pushes, I think there are conflicts here. Could you maybe just rebase on top tauri and ignore aa1b762 ?

Sorry, that's due to me using Sapling SCM for managing my work, and it does not work well in a collaborative environment with GitHub.

@martpie martpie merged commit 90514db into martpie:tauri Mar 17, 2024
3 of 4 checks passed
@martpie
Copy link
Owner

martpie commented Mar 17, 2024

Thank you! I am not a Rust person, so you will see a lot of non-idiomatic Rust in the current wip codebase for Tauri ;)

@uklotzde uklotzde deleted the logging branch March 17, 2024 11:16
martpie pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants