Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added probe X Y offset #163

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

Paciente8159
Copy link
Contributor

Implemented #152
Probe X/Y offset stored in settings.
Offset applied on G38.3 sending and then removed from parsed PRB parsed point.

- added probe X Y offset
@martin2250
Copy link
Owner

LGTM, going to test it on my machine and merge it soon. Thank you for your contribution!

@martin2250
Copy link
Owner

I have one request before merging this: please move the Textboxes for Offset X and Offset Y to the "Probing" tab in the settings window. Right now these settings are only shown when a height map is active and they also affect the output of the "Manual Probing" tab.

Thanks!

moved probe offset settings to Manual Probing options box
@martin2250 martin2250 merged commit cbafdbc into martin2250:master Apr 26, 2022
@martin2250
Copy link
Owner

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants