tidy POMs

chat-server/pom.xml

@@ -4,7 +4,7 @@
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
-    <!-- definition of parent Maven project -->
+    <!-- definition of the parent project, i.e. module inheritance -->
     <parent>
         <groupId>cz.muni.chat</groupId>
         <artifactId>chat-service-parent</artifactId>
@@ -17,10 +17,6 @@
     <name>Chat server</name>
     <description>Server for microservice implemented using Spring Boot</description>
 
-    <properties>
-        <java.version>17</java.version>
-    </properties>
-
     <!-- libraries needed in this module -->
     <dependencies>
         <dependency>
@@ -48,7 +44,7 @@
             <artifactId>commons-text</artifactId>
         </dependency>
 
-        <!-- simulate pagination from JPA without actually using JPA -->
+        <!-- for pagination from JPA without actually using JPA -->
         <dependency>
             <groupId>org.springframework.data</groupId>
             <artifactId>spring-data-commons</artifactId>
@@ -77,7 +73,7 @@
                 <groupId>org.springframework.boot</groupId>
                 <artifactId>spring-boot-maven-plugin</artifactId>
                 <!--
-                  starts and stops the built application during integration test so that
+                  starts and stops the built application during integration tests so that
                   * springdoc-openapi-maven-plugin can download generated openapi.yaml from it
                   * integration tests can use it
                 -->
@@ -126,6 +122,7 @@
 
             <!-- run integration tests in "mvn verify" phase -->
             <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
             </plugin>
         </plugins>

pom.xml

@@ -2,36 +2,54 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
+    <!-- parent project -->
+    <parent>
+        <groupId>org.springframework.boot</groupId>
+        <artifactId>spring-boot-starter-parent</artifactId>
+        <version>3.0.1</version>
+    </parent>
+
+    <!-- this project -->
     <groupId>cz.muni.chat</groupId>
     <artifactId>chat-service-parent</artifactId>
     <version>0.0.0-SNAPSHOT</version>
     <packaging>pom</packaging>
-
     <name>Chat service parent project</name>
     <description>Example web service with OpenAPI description</description>
     <organization>
         <name>Masaryk University</name>
         <url>https://www.muni.cz/</url>
     </organization>
     <inceptionYear>2022</inceptionYear>
+    <developers>
+        <developer>
+            <name>Martin Kuba</name>
+            <email>[email protected]</email>
+            <url>http://www.muni.cz/people/3988</url>
+            <organization>Masaryk University</organization>
+            <organizationUrl>https://www.muni.cz</organizationUrl>
+        </developer>
+    </developers>
 
-    <parent>
-        <groupId>org.springframework.boot</groupId>
-        <artifactId>spring-boot-starter-parent</artifactId>
-        <version>3.0.1</version>
-    </parent>
-
+    <!-- modules aggregation (commands are done in them too)  -->
     <modules>
         <module>chat-server</module>
         <module>chat-client-java-lib</module>
         <module>chat-client-java</module>
     </modules>
 
+    <!-- properties are inherited into children projects -->
+    <properties>
+        <java.version>17</java.version>
+    </properties>
+
     <build>
+        <!-- set that "mvn" alone means "mvn install" -->
         <defaultGoal>install</defaultGoal>
     </build>
 
-    <!-- set versions of dependencies in one place -->
+    <!-- set versions of dependencies for modules -->
     <dependencyManagement>
         <dependencies>
             <dependency>
@@ -46,4 +64,5 @@
             </dependency>
         </dependencies>
     </dependencyManagement>
+
 </project>