Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Issue Templates #1160

Closed
wants to merge 1 commit into from
Closed

Conversation

Sneethe
Copy link

@Sneethe Sneethe commented Dec 26, 2023

Following @mcepl concerns on noise and bloat in the issue tracker,. I added a page to redirect feature request issues to the mailing list.
In addition I also added a bug report page that prompts the user for useful information. I also thought it would be a good idea to add the mailing list and IRC to the landing page for more potential eyes on.

Currently you can see what these Issue templates look like here.

Please let me know if these are lacking in anyway. Maybe the Bug Report page could have some parts added/removed.

blank_issues_enabled: true
contact_links:
- name: IRC Channel
url: https://web.libera.chat/#vis-editor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRC URL should be ircs://irc.libera.chat:6697/vis-editor, shouldn’t it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure its that important. For the people who actively use IRC I think "#vis-editor on Libera" is sufficient without the link.

@mcepl
Copy link
Contributor

mcepl commented Dec 28, 2023

Aside from that nit, I think it should be workable.

Copy link
Collaborator

@rnpnr rnpnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this good, I will merge it soon if there are no further objections to the comments I left. Thanks for your help!

blank_issues_enabled: true
contact_links:
- name: IRC Channel
url: https://web.libera.chat/#vis-editor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure its that important. For the people who actively use IRC I think "#vis-editor on Libera" is sufficient without the link.

- type: markdown
attributes:
value: |
### The current practise is for feature discussion to take place in the vis [mailing list](https://lists.sr.ht/~martanne/devel).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might just reword this to:

The current practice and preferred location for large feature requests and general design discussion is the vis mailing list.

@rnpnr
Copy link
Collaborator

rnpnr commented Jan 23, 2024

Applied in f41860b. Thanks!

@goyalyashpal
Copy link

hi @ mcepl ninewise rnpnr

i saw here too: #1018 (comment)

that the commits are manually applied, rather than merging of the pr.
is there any special reason to it? what is the procedure you are following to accomplish that?

i am curious as i am always on the look out of how different people, or different repos manage their contributions and collaboration.

@rnpnr
Copy link
Collaborator

rnpnr commented Jan 24, 2024

hi @ mcepl ninewise rnpnr
Hi!

In general I don't use the github interface for applying patches. The process is a little different depending on where the patch came from.

If the patch came as a github pull request:

  1. I make a new branch locally
  2. I pull directly from the authors repo on github (for this patch git pull [email protected]:Sneethe/vis.git master)
  3. If the authors branch wasn't already on the tip of the master branch I rebase it.
  4. I then switch back to my local master and use git merge branch-name to apply the change.

If the patch came from email or the mailing list:

  1. I use git am < email directly on master

Once that is done I push the updated master to both sourcehut and github.

The criterion on githubs end for having the merged label appear on a pull request is that the commit hash from the merged repo must match the commit hash in the master repo. If I need to rebase the pull request on top of master and the author committed to a separate branch I can force push to their repo so that when I merge the hashes will be the same. Otherwise the hashes will be different and I have to manually close the PR.

(Me explaining this probably gives some good context as to why a lot of people prefer the mailing list based approach.)

@mcepl
Copy link
Contributor

mcepl commented Jan 25, 2024 via email

@mcepl
Copy link
Contributor

mcepl commented Jan 25, 2024 via email

@ninewise
Copy link
Collaborator

I usually apply patches from github similar to what is shown in the video linked, so yanking the PR URL, than curl -LOJ url.patch and git am 1160.patch. Someone recently told me github has allowed to do 'rebase and merge' since some time but it used to be just merging which is where I got the habbit. For vis, since we push to sourcehut (via a local copy), it's just easier to do everything there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants