-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow flask 3.0.x and werkzeug 3.0.x #572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 14 14
Lines 885 885
Branches 192 192
=======================================
Hits 884 884
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help on this.
I feel like we ought to add a specific tox env to test minimum versions of dependencies, like we did on webargs for instance, to be sure we don't use new Flask features without realizing it because the tests only test the latest version.
https://github.com/marshmallow-code/webargs/blob/dev/tox.ini
If you'd like to tackle this, you're more than welcome. Otherwise, let's just set 4.0 as max as per my comment and merge this for now. The minimum dependency versions test issue shouldn't block this.
@@ -1,14 +1,14 @@ | |||
#!/usr/bin/env python3 | |||
|
|||
from setuptools import setup, find_packages | |||
from setuptools import find_packages, setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, but out of curiosity, is this automatic reordering from a tool like PyCharm or something?
"werkzeug>=2.0.1,<3", | ||
"flask>=2.0.1,<3", | ||
"werkzeug>=2.0.1,<3.1", | ||
"flask>=2.0.1,<3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd set the max to 4.0. Things shouldn't break in between.
Superseded by #576. Thanks anyway. |
i had a look through the code and didn't see anything affected by any of the breaking changes