Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inline script (csp) #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ev-agelos
Copy link

Move javascript code from html files into their own .js files.
This will allow servers that have set "unsafe-inline" in their content security policy header to run the js code and render the swagger docs.

My use case is what I described above, I have set the Content Security Policy header for scripts to "unsafe-inline" and it did not let any inline js code to be run.

I am not expert in html/js so please let me know if I need to change anything.
I also did not lowered the swagger submitted methods as I saw the return value was already lowered, please let me know if this is not always true.

@lafrech
Copy link
Member

lafrech commented Jun 19, 2020

Sorry, I saw this, but didn't answer yet.

While ReDoc is easy to expose, swagger-ui is more of a pain (see open issues). I'd like to find a way to publish it with minimal maintenance burden.

I didn't find the time to dive into it yet.

There's a flask-swagger lib out there that packages swagger-ui. Maybe it addresses your issue.

Perhaps we should defer swagger-ui support to this lib (as an optional dependency).

@ev-agelos
Copy link
Author

Hey no worries, It may be a headache to support swagger-ui.
Thanks for the suggestion I will look into it.
I really like your plugin, it was exactly what I was looking for, so easy and nice to define args/schemas etc!
Feel free to reject the pr and Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants