Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Commit

Permalink
📚 notices about CRA 2 incompatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
mars authored Oct 2, 2018
1 parent 16e6ec7 commit f2368a6
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Ensure [requirements](#user-content-requires) are met, then execute the followin
✏️ *Replace `$APP_NAME` with the name for your unique app.*

```bash
npx create-react-app $APP_NAME
npx create-react-app@1.5.x $APP_NAME
cd $APP_NAME
git init
heroku create $APP_NAME --buildpack mars/create-react-app
Expand All @@ -86,12 +86,13 @@ Usage
✏️ *Replace `$APP_NAME` with the name for your unique app.*

```bash
npx create-react-app $APP_NAME
npx create-react-app@1.5.x $APP_NAME
cd $APP_NAME
```

* [npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b) comes with npm 5.2+ and higher, see [instructions for older npm versions](https://gist.github.com/gaearon/4064d3c23a77c74a3614c498a8bb1c5f)
* If [yarn](https://yarnpkg.com) is installed locally, the new app will use it instead of [npm](https://www.npmjs.com).
* if [yarn](https://yarnpkg.com) is installed locally, the new app will use it instead of [npm](https://www.npmjs.com)
* version 1.5.x is specified because [runtime env vars](#user-content-runtime-configuration) are not yet compatible with version 2.0.x ([issue #131](https://github.com/mars/create-react-app-buildpack/issues/131))

### Make it a git repo

Expand Down Expand Up @@ -384,6 +385,8 @@ REACT_APP_HEROKU_SLUG_COMMIT=$HEROKU_SLUG_COMMIT react-scripts build

Supports only [`REACT_APP_`](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-custom-environment-variables) prefixed variables.

🚨 *Not yet compatible with **Create React App 2** ([issue #131](https://github.com/mars/create-react-app-buildpack/issues/131))*

🚫🤐 ***Not for secrets.** These values may be accessed by anyone who can see the React app.*

Install the [runtime env npm package](https://www.npmjs.com/package/@mars/heroku-js-runtime-env):
Expand Down

0 comments on commit f2368a6

Please sign in to comment.