Upgraded plugin for Strapi 4.20 and NodeJS 20 #38
Conversation
There was a problem hiding this comment.
@BirknerAlex looks good to me!
@marlokessler can we merge this changes?
There was a problem hiding this comment.
Hi @BirknerAlex thank you for your contribution! Looks good to me!
|
@all-contributors please add @BirknerAlex for bug and code. |
|
I've put up a pull request to add @BirknerAlex! 🎉 |
| @@ -3,7 +3,7 @@ | |||
| "compilerOptions": { | |||
| "outDir": "dist", | |||
| "rootDir": ".", | |||
| "declaration": true | |||
| "declaration": true, | |||
There was a problem hiding this comment.
Oh true, good you catched that!
| @@ -1,9 +1,11 @@ | |||
| import { ReadStream, createReadStream, createWriteStream } from "fs"; | |||
| import { join } from "path"; | |||
| import sharp, { Sharp, Metadata } from "sharp"; | |||
| import { file as fileUtils } from '@strapi/utils'; | |||
There was a problem hiding this comment.
Hey, I tried to do the same but failed (@strapi/utils/dist/file was no longer exporting what we needed). How did you find out that it was moved to @strapi/utils, did you look at Strapi's source code changes?
There was a problem hiding this comment.
I just checked the latest source code where the utilty function has been moved.
https://github.com/search?q=repo%3Astrapi%2Fstrapi%20bytesToKbytes&type=code
Fixes #37