Refactor mos #16
Open
Refactor mos #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by other components. The goal was to make the code easier to maintain and follow should it need additional fixes in the future
…lso fixed various string comparisons that should be numeric comparisons
…at is sometimes missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the MOS parsing code in metar-v4.py into a separate module and rewrote it in a manner that I think will be much easier to maintain in the future. Also fixed some data types so comparisons are numeric rather than string.
The motivation for this change was that it was easier to do this to add support for TMP than it was to merge TMP processing into existing code. I am working on a feature to also show temperatures and needed TMP support for this to work with the MOS data.
I did not update metar-display-v4.py to use the new MOS module, I do not have a display to test with but I see no reason making similar changes that I made in metar-v4.py would not work.