Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated bin/setup-ssl to support multi site ssl generation #1200

Open
wants to merge 1 commit into
base: release/next
Choose a base branch
from

Conversation

nathanchick
Copy link

@nathanchick nathanchick commented Jul 29, 2024

This PR re-adds support for multiple domain SSL generation while maintaining stripping ports from each domain.

Fixes: #1172

Copy link

what-the-diff bot commented Jul 29, 2024

PR Summary

  • Enhancement in setup-ssl script
    The setup-ssl script is now improved to handle multiple domains. This means it can process not just a single domain, but several at once, providing greater versatility and efficiency in setting up secure connections.

  • Stripping the Port Number
    The script now has an added capacity to remove port numbers from each domain passed to it, ensuring cleaner, more standardized inputs for certificate generation.

  • New Array of 'Port-less' Domains
    An array is populated with all the provided domains, after removing their respective port numbers. This improves data organization and handling within the script.

  • Updated mkcert Command
    The mkcert command, used for locally trusted development certificates, has now been updated to use the newly generated array of domains. This promotes better integrity and traceability between the multiple domains being processed.

@ssx
Copy link

ssx commented Jul 29, 2024

@markshust can we get some eyes on this? currently breaking out workflows internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL For Multi Site Not
2 participants