-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL For Multi Site Not #1172
Comments
Hi, @epeetsTS Thank you for reporting this issue. I have identified and resolved the problem with the I have updated the You can now run the command as follows:
This will generate and install SSL certificates for your domains correctly. Let me know if you encounter any further issues. |
@YevhenZvieriev Unfortunately, even though this does work to generate an ssl for each domain and eliminates the error, it causes another problem with creating an ssl for a SINGLE domain instead for the domains requested. The cert and key overwrite each other in the for loop and in the end you only have an SSL for the latest domain and not all of them. Since this was working before. My solution was simply to revert back to an old commit for the bin/setup-ssl from 2023 (linked below) which works as expected generating a single ssl for multiple domains. |
I could make it work based on a script that I found on some fork here. However, I can't find it anymore. This is what I did. I created a new bin/setup-ssl-new script
This iterates over the domains and creates the certificate for each domain under its specific name. Then I created images/nginx/conf/default.conf
Make sure you that different from the default.conf that was in a video tutorial that says this listen [::]:8443 ssl http2 ipv6only=on; you remove ipv6only=on Otherwise the app container won't run |
@YevhenZvieriev ssl also not working for me. do you have any idea what is the solution. sometime multiwebsite also not created. i don't know why? |
@bhushanmeetanshi I came across this issue this morning so I've just written a quick PR to solve it. |
Seems the fix from @nathanchick worked on my end |
Description
When I run the command to setup SSL with more than one domain. Instead of generating SSLS for the requested domains, it tries to generate an SSL for a bad domain name made up of the requested domains.
Steps To Reproduce
bin/setup-ssl <domain name> <domain name>
Expected Result
Generated SSLs for each domain name.
Actual Result
ERROR: " " is not a valid hostname, IP, URL or email
The text was updated successfully, but these errors were encountered: