Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup #2309

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Fix cleanup #2309

merged 7 commits into from
Oct 1, 2024

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Oct 1, 2024

Description

  • Change scope cleanup strategy - instead of registering cleanups with the owner scope, adds a cleanup-owner to the scope which is the upstream conditional scope.
  • Bonus changes
    • Fixes some child scopes getting serialized but not used in resume leaning to undefined start/end nodes
    • Fixes downstream intersections of intersection signals not being written in dom compilation
    • Change signals referenced in module scope (e.g. intersections, closures, args) in dom compilation are now lazily evaluated which makes signal ordering irrelevant. This change does not alter signal ordering.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 2526135

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-interop-class-tags Patch
@marko/translator-tags Patch
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 96.62162% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (4d8eb53) to head (2526135).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/resume.ts 92.72% 3 Missing and 1 partial ⚠️
packages/runtime-tags/src/dom/signals.ts 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
+ Coverage   88.10%   88.19%   +0.08%     
==========================================
  Files         340      340              
  Lines       35345    35504     +159     
  Branches     2060     2086      +26     
==========================================
+ Hits        31141    31313     +172     
+ Misses       4187     4175      -12     
+ Partials       17       16       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq merged commit 2a971ce into main Oct 1, 2024
9 checks passed
@rturnq rturnq deleted the fix-cleanup branch October 1, 2024 20:57
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant