This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Fix minimist vulnerability #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was against |
|
Reopening per suggestion from owners. |
|
This PR is limited to updates to the dependency versions. Looks good to me. |
|
It seemed nodemon needed an update as well to get it fully clean, at least at my end. Funny that doing an npm update in this repo resulted in 5 warnings that refused to get fixed, whereas updating only underscore, nodemon, and mocha, and some additional npm audit fix's worked fine. |
|
I pushed your changes together with the nodemon one into dev, and merged that into master. I think this PR is obsolete now.. |
|
Thanks, @grtjn! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #61 as well as other problems found with
npm audit.