Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject disabled fields #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reject disabled fields #70

wants to merge 4 commits into from

Conversation

serverglitch
Copy link

Originally done by @samlown in #18. Separated the disabled field rejection into its own commit.

@sockmonk
Copy link

I would love to see this merged. Disabled input fields should not be serialized or submitted to the server.

@rhubarbselleven
Copy link
Contributor

Hi @sockmonk can you expand on the usecase as to why disabled input fields should not be serialized?

@samccone
Copy link
Member

I think the idiomatic thing to do is to not submit disabled fields

screen shot 2015-02-25 at 6 24 14 pm

For example http://jsfiddle.net/00bqLtsp/

@rhubarbselleven
Copy link
Contributor

Syphon is only to get you from form to object however. Submission is another beast.

I think the middle ground will be somewhere between here and #72

@samccone
Copy link
Member

true true :) just leaning on the giants for some perspective

@rhubarbselleven
Copy link
Contributor

Ah good point @samccone

@rhubarbselleven
Copy link
Contributor

Hey @serverglitch would you mind opening this against the major branch? And could you fixup the failing tests please?

@wmadden wmadden mentioned this pull request Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants