feat: add support for --watch flag #65
Open
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgrant
changed the title
gabrielgrant
force-pushed
the
add-watch-flag
branch
from
a6d1a33 to
2721a7e
Compare
tests don't use the default config, so shouldn't expect the --watch flag unless explicitly set
gabrielgrant
force-pushed
the
add-watch-flag
branch
from
b865513 to
65d6506
Compare
mscolnick
reviewed
Jan 15, 2025
| @@ -48,6 +48,7 @@ You can configure the extension using the following settings: | |||
| - `marimo.browserType`: Browser to open marimo app (`system` or `embedded`, default: `embedded`) | |||
| - `marimo.port`: Default port for marimo server (default: `2818`) | |||
| - `marimo.sandbox`: Always start marimo in a sandbox, e.g. `marimo edit --sandbox` (default: `false`). Requires [`uv`](https://docs.astral.sh/uv/) to be installed. | |||
| - `marimo.watch`: Always start marimo with the `--watch` flag (default: `true`). | |||
There was a problem hiding this comment.
thank you! this is a great addition and good default
There was a problem hiding this comment.
thanks for doing the main implementation!
|
the tests might have gotten stale. i will look into them. also will add CI checks and look at the outstanding issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--watchseems very useful when using marimo within an editor so that edits within the editor (or automatic changes like symbol renames etc) are reflected in the notebook (vs today when those changes get silently overwritten by marimo)Should not be merged before marimo support for
--watchis released in marimo-team/marimo#3437Based on #57
Note: in running tests locally, I'm seeing a bunch of failures in the export_as and convert tests (separate from these edits)