Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add typoegraphy setting for slides #2247

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Sep 6, 2024

Add prose-slides to make all typography elements larger.

Screenshot 2024-09-06 at 10 10 06 AM
image

This should help with #2125

Some ui elements are harder to override and may need another pass:

  • accordion
  • tabs

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 2:12pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 2:12pm

@@ -82,7 +82,7 @@ def build_ui_plugin(

attrs: list[str] = [_build_attr("initial-value", initial_value)]
if label is not None and label:
attrs.append(_build_attr("label", _md(label, size="sm").text))
attrs.append(_build_attr("label", _md(label).text))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshayka this could be a controversial change (it effects sizes outside of slides)

@mscolnick mscolnick merged commit fce54df into main Sep 6, 2024
31 checks passed
@mscolnick mscolnick deleted the ms/prose-slides branch September 6, 2024 17:04
Copy link

github-actions bot commented Sep 6, 2024

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.8.12-dev13

@TimWalter
Copy link

How can one use this prose-slides feature?

@mscolnick
Copy link
Contributor Author

hi @TimWalter - the sizing should automatically take effects when you switch to the Slides view, since version 0.8.12

@mscolnick mscolnick mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants