fix: allow backslashes in app config (file format) #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
previously approved these changes
Sep 4, 2024
Serialize string kwargs to the App constructor as r-strings to allow for backslashes in file paths (windows).
akshayka
force-pushed
the
aka/fix-file-format-r-string
branch
from
a2a4dc5
to
6788b63
Compare
mscolnick
approved these changes
Sep 4, 2024
|
Do we need to do this for layouts? We put them in a subdirectory too, I just haven't see anyone have issues |
This change escapes backslashes all string arguments, so it will apply to layouts too (if the layout has a backslash). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape backslashes in app config strings.
Fixes #2202