-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mo.ui.datetime, mo.ui.date_range #2174
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for two small comments
label: Optional[str] = None, | ||
on_change: Optional[Callable[[Optional[dt.datetime]], None]] = None, | ||
full_width: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make these keyword only, similar to mo.ui.date
label: Optional[str] = None, | ||
on_change: Optional[Callable[[Tuple[dt.date, dt.date]], None]] = None, | ||
full_width: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should also be keyword-only
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.8.8-dev7 |
This adds
mo.ui.datetime
andmo.ui.date_range