Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DST-450]: rework design #56

Merged
merged 21 commits into from
Jun 3, 2024
Merged

[DST-450]: rework design #56

merged 21 commits into from
Jun 3, 2024

Conversation

aromko
Copy link
Contributor

@aromko aromko commented May 24, 2024

Focus on general layout and compound component as first example. The latest update from state management isn't merged currently.
Also added the demo preview.

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reference-app ✅ Ready (Inspect) Visit Preview 7 resolved Jun 3, 2024 11:00am

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 77.45098% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 56.55%. Comparing base (731f3b1) to head (177016b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
- Coverage   75.97%   56.55%   -19.43%     
===========================================
  Files          14       16        +2     
  Lines         383      458       +75     
  Branches       16       17        +1     
===========================================
- Hits          291      259       -32     
- Misses         92      194      +102     
- Partials        0        5        +5     
Files Coverage Δ
src/components/App.tsx 100.00% <100.00%> (ø)
src/components/DemoLink.tsx 100.00% <100.00%> (ø)
src/components/SideNavigation.tsx 100.00% <100.00%> (ø)
...components/state-management/StateManagementApp.tsx 100.00% <100.00%> (ø)
src/components/Preview.tsx 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@tirado-rx tirado-rx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marcel, see my comments on the board for my review. In general, you want to make as few design decisions as necessary before user testing, so I think that most design work will follow after the tests.

If you like, we can also discuss the scope and requirements of the product together in order to decide which recommendations (if any) are most important to implement now.

src/components/DemoLink.tsx Outdated Show resolved Hide resolved
src/components/DemoLink.tsx Outdated Show resolved Hide resolved
sebald
sebald previously approved these changes Jun 3, 2024
@sebald sebald merged commit 79e6b01 into main Jun 3, 2024
10 checks passed
@sebald sebald deleted the DST-450_rework-design branch June 3, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants