Anthonyaue/remove cr #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate files since they don't play nice with the existing bits.
Add parallel build files to build usable minimal shared sentencepiece dll with MSVC
1. download protobuf-cpp-<version>.zip file using powershell 2. bakup CMakeLists.txt and override with CMakeLists_minexport in both the root and src folder
2. open readable file as binary stream for text file to avoid reading partial file due to u0x1a
…z_in_input_file 1. open readable file in "in" mode vs. "out" mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gary's change to read files as binary (to work around ^Z terminating input) had the negative side effect that when we read Windows-encoded (CRLR) files, we end up with an extra carriage return on each line. This pulls that off with some code from Frank.