static link Threads lib for a portable bin (#1012)

* static link Threads lib for a portable bin * Changelog: Threads to EXT_LIBS --------- Co-authored-by: Thamme Gowda <[email protected]>
marian-nmt · Nov 22, 2023 · ba5df66 · ba5df66
1 parent 26a392b
commit ba5df66
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 - Fixed compilation with clang 16.0.6
+- Added Threads::Threads to EXT_LIBS
+
 
 ### Added
 - Added `--no-spm-encode` option, allowing the model to use vocabulary IDs directly to train/decode.

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -80,6 +80,15 @@ if(NOT CMAKE_BUILD_TYPE)
  set(CMAKE_BUILD_TYPE "Release")
 endif()
 
+########
+# pThreads: consider it as EXT_LIBS for a more portable binary
+set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
+set(THREADS_PREFER_PTHREAD_FLAG TRUE)
+find_package(Threads REQUIRED)
+set(EXT_LIBS ${EXT_LIBS} Threads::Threads)
+########
+
+
 ###############################################################################
 # Set compilation flags
 if(MSVC)