feat: add support for react-native v0.73 #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native v0.73 changed a few internal classes regarding ShadowNodes. I've updated the corresponding headers and function calls to the best of my knowledge. The current state compiles, but I've commented out the "adopt" function call in `MGContentContainerComponentDescriptor.h`, because I couldn't get the types to work properly. It would be nice if someone could help me with that :) Other than that, I want to thank the entire margelo team for creating this amazing library. Please don't be discouraged to work this library. You've truly created something revolutionary, which has a bright future for the react-native space.
|
@SamuelScheit It seems that in XCode 15.3, it doesn't build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native v0.73 changed a few internal classes regarding ShadowNodes.
I've updated the corresponding headers and function calls to the best of my knowledge.
The current state compiles, but I've commented out the "adopt" function call in
MGContentContainerComponentDescriptor.h, because I couldn't get the types to work properly. It would be nice if someone could help me with that :)Other than that, I want to thank the entire margelo team for creating this amazing library.
Please don't be discouraged to work on this library. You've truly created something revolutionary, which has a bright future for the react-native space.