updated apt hooks #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also dropped the APT::Periodic::Update-Package-Lists hook |
margau
requested changes
Feb 2, 2022
| # this is the apt hook provided by the pve exporter. This file shall be placed under /etc/apt/apt.conf.d | ||
| APT::Update::Pre-Invoke {"touch /tmp/pkg-exporter-apt-update-pre"; }; | ||
| APT::Update::Post-Invoke {"touch /tmp/pkg-exporter-apt-update-post"; }; | ||
| APT::Periodic::Update-Package-Lists "1"; |
There was a problem hiding this comment.
In my opinion, we should leave that line as commented suggestion in the example
| APT::Update::Post-Invoke {"touch /tmp/pkg-exporter-apt-update-post"; }; | ||
|
|
||
| # These hooks ensure the metrics are automatically updated when apt is run | ||
| APT::Update::Post-Invoke-Success {"/usr/local/bin/pkg-exporter"}; |
There was a problem hiding this comment.
Until we provide a debian package, also those shall be a commented suggestion, as we do not yet have a single way of installation.
In my optionion starting a systemd unit (if present) would be better than calling the binary directly, however that needs some work on the systemd side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will solve issue #13
And there is no longer a need to setup a cron job, or systemd timer