Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GGML_USE_CUBLAS when CT_HIPBLAS is defined #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muaiyadh
Copy link

Hi,

I couldn't install the library with HIPBLAS because of missing CUDA stuff.
Turns out there was an extra option for compiling with CUBLAS when CT_HIPBLAS is defined.

Also, should fix #134 and #135

@bugfixin
Copy link

Trying this myself, it seems to work, thank you!

@CrashTD
Copy link

CrashTD commented Sep 18, 2023

Still does not build for me. However, the log is now significant shorter.
https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36

maybe just a incompatibility with the still relatively new gfx1101?

@bugfixin
Copy link

Still does not build for me. However, the log is now significant shorter. https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36

maybe just a incompatibility with the still relatively new gfx1101?

It looks like your compilation is using the standard system compilers (cc and c++), try setting the environment variables CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" (you can prepend that to the pip install command), e.g. CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" CT_HIPBLAS=1 pip install ctransformers --no-binary ctransformers

@CrashTD
Copy link

CrashTD commented Sep 19, 2023

It looks like your compilation is using the standard system compilers (cc and c++), ...

That in combination with the removal of the CUBLAS line fixed it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile for ROCM on Ubuntu 22.04
3 participants