Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character conversion #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Character conversion #40

wants to merge 5 commits into from

Conversation

havet
Copy link
Contributor

@havet havet commented Feb 13, 2016

Added character conversion on:

  1. Listing files
  2. Uploading files

Now file names with national characters are displayed properly and are preserved on uploading.

@havet
New option: hashed passwords
53dd69b 
Added an option to store the passwords in hashed form.
@havet
Added some more translations to Swedish
c3399c7 
Added missing lines in the Swedish translation.
@havet
Corrected the Swedish translation
6ddab60 
Changed to national characters.
@havet
Comments
5495076 
Changed some comments.
@havet
Fixed file name bug
6a82d1b 
Added character conversion on:
1) Listing files
2) Uploading files
@marekrei
Copy link
Owner

If I understand correctly, you are assuming that the filenames are encoded in ISO-8859-1 and then convert them to UTF-8 with iconv().
This might work well for the Swedish filenames, but what happens for everyone else who doesn't use ISO-8859-1? My filenames for example are all UTF-8 already, and a wide range of other encodings are possible.

I can see you've set $_CONFIG['charset'] = "ISO-8859-1"; in the code, which seems like the better solution, but then commented it out. Why did you not stick with that?

NewEraCracker added a commit to NewEraCracker/encode-explorer that referenced this pull request Apr 5, 2016
@NewEraCracker
Make translate_encoding generic
efc8aa1 
Will make easier the implementation of marekrei#40 and later fixing of marekrei#37
NewEraCracker added a commit to NewEraCracker/encode-explorer that referenced this pull request Jul 31, 2016
@NewEraCracker
Fixes for marekrei#42, marekrei#40 and marekrei#37
a6a0d51 
Encoding translation is now more transparent and handled in a logical,
albeit hackish, way.

Thanks to @havet and @kofbox for their feedback.
Will be followed by a commit that handles the basename() issue.

Tested and working when encode-explorer is running on Windows platform.
NewEraCracker added a commit to NewEraCracker/encode-explorer that referenced this pull request Jul 31, 2016
@NewEraCracker
Fixes for marekrei#42, marekrei#40 and marekrei#37
da86c69 
Encoding translation is now more transparent and handled in a logical,
albeit hackish, way.

Thanks to @havet and @kofbox for their feedback.
Will be followed by a commit that handles the basename() issue.

Tested and working when encode-explorer is running on Windows platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havet @marekrei