Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

Fix caching under pip 9 #84

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Fix caching under pip 9 #84

merged 2 commits into from
Aug 8, 2017

Conversation

Roguelazer
Copy link
Contributor

As far as I can tell, pip 9 requires all of the following to cache a downloaded file in the local HTTP cache:

  • link includes #md5=
  • ETag set to a value matching the md5
  • Date and Cache-Control headers set appropriately

I haven't tested this under 1.3.0 yet, but we're running this locally applied against 1.2.2 and it fixed HTTP response caching for us.

@Roguelazer
Copy link
Contributor Author

(sorry, the original branch included a spurious commit; I've rebased it out)

@mardiros
Copy link
Owner

mardiros commented Aug 8, 2017

Thanks for the work!

@mardiros mardiros merged commit 8a4a774 into mardiros:master Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants